Github user jmahonin commented on the pull request:

    https://github.com/apache/phoenix/pull/137#issuecomment-160761094
  
    Hi @gliptak 
    
    I tried to run the tests with the patch applied, and got a number of 
failures. I think that 'beforeAll' and 'afterAll' aren't actually getting 
invoked in with the JUnitSuite for some reason.
    
    I tried adding the '@BeforeClass' and '@AfterClass' annotations, but JUnit 
warns that the methods should be static. Sadly, I think the only way to make 
that work is with a companion object (e.g. 'object PhoenixSparkIT' which 
contains the beforeAll and afterAll definitions).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to