[ 
https://issues.apache.org/jira/browse/PHOENIX-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036907#comment-15036907
 ] 

ASF GitHub Bot commented on PHOENIX-2481:
-----------------------------------------

Github user JamesRTaylor commented on the pull request:

    https://github.com/apache/phoenix/pull/141#issuecomment-161471331
  
    Awesome, @ndimiduk - I love it. Couple of questions and some nits:
    - For JSON, is only single level supported? If not, how is nested JSON 
handled?
    - Looks like lists are converted into ARRAYs which is nice. What happens if 
the array elements have different data types? I guess you'd just log an error 
and ignore that row?
    - Can you make sure the indenting conforms to the 4 space convention?
    - Also, please make sure imports don't use * and that their order is 
correct (see dev/phoenix.importorder and dev/eclipse_prefs_phoenix.epf).
    
    @gabrielreid - got a few spare cycles for a review?



> JSON Bulkload Tool
> ------------------
>
>                 Key: PHOENIX-2481
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2481
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>
> Would be nice to be able to load JSON directly, as we can CSV.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to