Github user jmahonin commented on the pull request:
https://github.com/apache/phoenix/pull/142#issuecomment-162212491
This is a good idea. There are actually a few implementations of DBWritable
in the codebase:
- PhoenixRecordWritable
- PhoenixPigDBWritable
- PhoenixIndexDBWritable
The code seems very similar across implementations, so we definitely should
have one base implementation that works well across the board and can be simply
extended, if need be. Having it in 'phoenix-core' is a bonus too.
I'd like to see the phoenix-spark 'PhoenixRecordWritable' renamed to maybe
'PhoenixSparkRecordWritable' and have it trimmed down to implement this new
class, but maybe that's better suited to a follow-up PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
