[
https://issues.apache.org/jira/browse/PHOENIX-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15051904#comment-15051904
]
James Taylor commented on PHOENIX-2497:
---------------------------------------
Looks good, [~tdsilva]. One minor fix on commit nit:
Instead of this code
{code}
+ private boolean hasRowTimestampColumn (PTable table) {
+ for (PColumn col : table.getColumns()) {
+ if (col.isRowTimestamp())
+ return true;
+ }
+ return false;
+ }
{code}
Use PTable.getRowTimestampColPos() >= 0. Might be worth adding a
SchemaUtil.hasRowTimestampColumn(PTable) utility method. If you don't do that,
make that method static.
> Disallow usage of ROW_TIMESTAMP with transactional tables
> ---------------------------------------------------------
>
> Key: PHOENIX-2497
> URL: https://issues.apache.org/jira/browse/PHOENIX-2497
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: James Taylor
> Assignee: Thomas D'Silva
> Fix For: 4.7.0
>
> Attachments: PHOENIX-2497.patch
>
>
> We should throw an exception when an attempt is made to create a
> transactional table or alter an existing table that uses the ROW_TIMESTAMP
> declaration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
