[ 
https://issues.apache.org/jira/browse/PHOENIX-2434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055850#comment-15055850
 ] 

Hudson commented on PHOENIX-2434:
---------------------------------

SUCCESS: Integrated in Phoenix-master #1021 (See 
[https://builds.apache.org/job/Phoenix-master/1021/])
PHOENIX-2434 Improve booleans in CSV import (gabrielr: rev 
e8a7feedb260bbb4c5abc88ab5e3325f98176ee9)
* phoenix-core/src/main/java/org/apache/phoenix/util/csv/CsvUpsertExecutor.java
* 
phoenix-core/src/test/java/org/apache/phoenix/util/AbstractUpsertExecutorTest.java
* 
phoenix-core/src/test/java/org/apache/phoenix/util/csv/CsvUpsertExecutorTest.java


> CSV loader: fail on invalid booleans
> ------------------------------------
>
>                 Key: PHOENIX-2434
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2434
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Bruno Dumon
>             Fix For: 4.7.0
>
>         Attachments: PHOENIX-2434-rebased.patch, PHOENIX-2434.patch
>
>
> Currently the CSV loader parses boolean values using Boolean.parseBoolean(), 
> indirectly via PBoolean.toObject(String). This recognizes the string "true" 
> (ignoring case) as true, anything else is false.
> This is not very friendly to the user, who might for example think that '1' 
> is true and '0' is false. It would be better to fail on invalid input, just 
> like is the case for invalid numbers or invalid dates.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to