[
https://issues.apache.org/jira/browse/PHOENIX-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083562#comment-15083562
]
Hadoop QA commented on PHOENIX-2563:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12780583/PHOENIX-2563.patch
against master branch at commit 8d3c778a923672ae708b381ea817fa7bd44babb8.
ATTACHMENT ID: 12780583
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
33 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/211//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/211//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/211//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/211//console
This message is automatically generated.
> Pherf's ResourceList should fail gracefully if a Jar file doesn't exist
> -----------------------------------------------------------------------
>
> Key: PHOENIX-2563
> URL: https://issues.apache.org/jira/browse/PHOENIX-2563
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Minor
> Fix For: 4.7.0
>
> Attachments: PHOENIX-2563.patch
>
>
> {code}
> ZipFile zf;
> try {
> zf = new ZipFile(file);
> } catch (final ZipException e) {
> throw new Error(e);
> } catch (final IOException e) {
> throw new Error(e);
> }
> {code}
> I had a symlink in my {{$HBASE_HOME/lib}} to a jar file that didn't actually
> exist on the filesystem. This in itself is fine, but when pherf scanned
> through the classpath looking for the xml scenario/schema files, it failed
> because we couldn't open this file.
> It would be much nicer if this code returns an empty list instead of throwing
> an Error (also, why Error and not RuntimeException).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
