[ 
https://issues.apache.org/jira/browse/PHOENIX-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112108#comment-15112108
 ] 

James Taylor edited comment on PHOENIX-2621 at 1/22/16 9:11 AM:
----------------------------------------------------------------

[~tdsilva] - lots of issues with your test. Please review the patch. Biggest 
issues:
- you weren't creating unique row keys because you were doing a get of the 
current atomic and an increment separately
- you were interrupting the threads which gives no guarantee in where it was 
stopped. It's actually not a bad test for transactions, but won't work for non 
transactions (i.e. the thread may get interrupted after sending the data table 
batch but before sending the index table batch)

Otherwise, a more minor issue was the shear amount of data being created.


was (Author: jamestaylor):
[~tdsilva] - lots of issues with your test. Please review the patch.

> ImmutableIndexIT is failing
> ---------------------------
>
>                 Key: PHOENIX-2621
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2621
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>             Fix For: 4.7.0
>
>         Attachments: PHOENIX-2621.patch, PHOENIX-2621.patch
>
>
> ImmutableIndexIT is flapping in the latest builds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to