[
https://issues.apache.org/jira/browse/PHOENIX-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114426#comment-15114426
]
Josh Mahonin commented on PHOENIX-2464:
---------------------------------------
This didn't actually get resolved.
[~gliptak] made a valiant effort to port these over, but at the expense of the
tests taking 2-4x longer than previously.
There's a few lines of code which act as a helper for the Spark/Scala tests
which extend BaseHBaseManagedTimeIT [1]. It's not ideal, but it's pretty small
and contained. I'm not sure the drawbacks of slowing down the testing time
outweigh the benefits of slightly simplifying the test setup.
[1]
https://github.com/apache/phoenix/blob/master/phoenix-spark/src/it/scala/org/apache/phoenix/spark/PhoenixSparkIT.scala#L39-L48
> phoenix-spark module should use 'JUnitSuite' instead of 'FunSuite'
> ------------------------------------------------------------------
>
> Key: PHOENIX-2464
> URL: https://issues.apache.org/jira/browse/PHOENIX-2464
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.6.0
> Reporter: Josh Mahonin
> Assignee: Josh Mahonin
> Fix For: 4.8.0
>
>
> The existing phoenix-spark tests use the 'FunSuite' from ScalaTest, but in
> order to properly inherit other JUnit annotations like '@ClassRules' from the
> base tests [1], it should be using 'JUnitSuite' instead.
> Issue exposed in PHOENX-2462
> [1] https://groups.google.com/forum/#!topic/scalatest-users/ayjVDbNiOas
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
