[ https://issues.apache.org/jira/browse/PHOENIX-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143972#comment-15143972 ]
maghamravikiran commented on PHOENIX-2674: ------------------------------------------ Good catch [~jesse_yates] on the missing usage of condition clause. +1 for the changes. > PhoenixMapReduceUtil#setInput doesn't honor condition clause > ------------------------------------------------------------ > > Key: PHOENIX-2674 > URL: https://issues.apache.org/jira/browse/PHOENIX-2674 > Project: Phoenix > Issue Type: Bug > Reporter: Jesse Yates > Assignee: Jesse Yates > Attachments: PHOENIX-2674.patch, phoenix-2674-v0-without-test.patch > > > The parameter is completely unused in the method. Further, it looks like we > don't actually test this method or any m/r tools directly. > It would be good to (a) have explicit tests for the MapReduce code - rather > than relying on indirect tests like the index util - and, (b) have an example > in code for using the mapreduce tools, rather than just the web docs (which > can become out of date). -- This message was sent by Atlassian JIRA (v6.3.4#6332)