[ 
https://issues.apache.org/jira/browse/PHOENIX-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178032#comment-15178032
 ] 

James Taylor commented on PHOENIX-2575:
---------------------------------------

bq. Yes James Taylor It's broken with latest version.
Did you know this when HBASE-14643 was patched? Was there any discussion around 
this to see if an alternative approach could be made? This puts Phoenix in a 
crappy position.

We'll need to adjust the code that determines when local indexing is supported 
in ConnectionQueryServicesImpl and update the website page on secondary indexes 
with this information too:
{code}
    private final Map<Feature, FeatureSupported> featureMap = 
ImmutableMap.<Feature, FeatureSupported>of(
            Feature.LOCAL_INDEX, new FeatureSupported() {
                @Override
                public boolean isSupported(ConnectionQueryServices services) {
                    int hbaseVersion = services.getLowestClusterHBaseVersion();
                    return hbaseVersion < 
PhoenixDatabaseMetaData.MIN_LOCAL_SI_VERSION_DISALLOW || hbaseVersion > 
PhoenixDatabaseMetaData.MAX_LOCAL_SI_VERSION_DISALLOW;
                }
            },
{code}

> Prevent LocalIndexIT from hanging indefinitely
> ----------------------------------------------
>
>                 Key: PHOENIX-2575
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2575
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Rajeshbabu Chintaguntla
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2575.patch, PHOENIX-2575.patch
>
>
> On one of the test runs on 4.x-HBase-1.0, I see that the LocalIndexIT class 
> didn't complete. Run - 
> https://builds.apache.org/job/Phoenix-4.x-HBase-1.0/300/console. This is an 
> attempt to prevent the indefinite hang by adding a timeout to count down 
> latches.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to