[
https://issues.apache.org/jira/browse/PHOENIX-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209663#comment-15209663
]
ASF GitHub Bot commented on PHOENIX-2722:
-----------------------------------------
Github user maryannxue commented on the pull request:
https://github.com/apache/phoenix/pull/154#issuecomment-200637757
@ankitsinghal Thank you very much for the pull request! I am impressed by
how many details you have taken into account in your commit. It took me quite a
while to go through all of the changes. That said, it would be great if you
could add more test cases covering most (if not all) of the code changes, e.g.
the join case (left outer join w/ offset and w/wo limit), the derived table
case, the join with subquery case, etc.
Check JoinCompiler.isFlat(SelectStatement), it returns true only when limit
== null, think it should be the same for offset. That function is called when a
join contains a subquery, e.g. "select * from (select a, b from t1 offset 3)
join (select c, d from t2 limit 10)".
> support mysql "limit,offset" clauses
> -------------------------------------
>
> Key: PHOENIX-2722
> URL: https://issues.apache.org/jira/browse/PHOENIX-2722
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Ankit Singhal
> Assignee: Ankit Singhal
> Priority: Minor
> Attachments: PHOENIX-2722.patch, PHOENIX-2722_formatted.patch
>
>
> For serial query(query with “serial" hint or “limit" without "order by”), we
> can limit each scan(using page filter) to “limit+offset” instead of limit
> earlier.
> And then, for all queries, we can forward the relevant client iterators to
> the offset provided and then return the result.
> syntax
> {code}
> [ LIMIT { count } ]
> [ OFFSET start [ ROW | ROWS ] ]
> [ FETCH { FIRST | NEXT } [ count ] { ROW | ROWS } ONLY ]
> {code}
> Some new keywords(OFFSET,FETCH,ROW, ROWS,ONLY) are getting introduced so
> users might need to see that they are not using them as column name or
> something.
> WDYT, [~jamestaylor]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
