Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/153#discussion_r58117457
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
 ---
    @@ -2910,6 +3026,16 @@ private static MetaDataMutationResult 
checkTableKeyInRegion(byte[] key, Region r
                     EnvironmentEdgeManager.currentTimeMillis(), null);
         }
     
    +    private static MetaDataMutationResult checkSchemaKeyInRegion(byte[] 
key, Region region) {
    --- End diff --
    
    You should reuse checkTableKeyInRegion and rename it to checkKeyInRegion. 
You would pass MutationCode to include in the result an extra parameter when 
the key is not in region. While you are it, also please remove the method 
checkFunctionKeyInRegion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to