Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/154#discussion_r58469287
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/OrderedResultIterator.java
---
@@ -130,9 +135,9 @@ public OrderedResultIterator(ResultIterator delegate,
List<OrderByExpression> or
SizedUtil.OBJECT_SIZE + estimatedRowSize;
// Make sure we don't overflow Long, though this is really
unlikely to happen.
- assert(limit == null || Long.MAX_VALUE / estimatedEntrySize >=
limit);
+ assert (limit == null || Long.MAX_VALUE / estimatedEntrySize >=
limit + this.offset);
--- End diff --
Nit: remove space before assert
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
