[
https://issues.apache.org/jira/browse/PHOENIX-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225346#comment-15225346
]
ASF GitHub Bot commented on PHOENIX-2722:
-----------------------------------------
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/154#discussion_r58469780
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/execute/CorrelatePlanTest.java ---
@@ -172,17 +172,38 @@ public void testCorrelatePlanWithSingleValueOnly()
throws SQLException {
{2, "2", "2", 20},
{5, "5", "5", 100},
};
- testCorrelatePlan(LEFT_RELATION, rightRelation, 1, 0,
JoinType.Inner, expected);
+ testCorrelatePlan(LEFT_RELATION, rightRelation, 1, 0,
JoinType.Inner, expected);
}
- private void testCorrelatePlan(Object[][] leftRelation, Object[][]
rightRelation, int leftCorrelColumn, int rightCorrelColumn, JoinType type,
Object[][] expectedResult) throws SQLException {
+ @Test
--- End diff --
Also, test for bind parameter for OFFSET, like this:
SELECT * FROM T OFFSET ?
And check that the ResultSetMetaData and ParameterMetaData are ok.
> support mysql "limit,offset" clauses
> -------------------------------------
>
> Key: PHOENIX-2722
> URL: https://issues.apache.org/jira/browse/PHOENIX-2722
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Ankit Singhal
> Assignee: Ankit Singhal
> Priority: Minor
> Attachments: PHOENIX-2722.patch, PHOENIX-2722_formatted.patch
>
>
> For serial query(query with “serial" hint or “limit" without "order by”), we
> can limit each scan(using page filter) to “limit+offset” instead of limit
> earlier.
> And then, for all queries, we can forward the relevant client iterators to
> the offset provided and then return the result.
> syntax
> {code}
> [ LIMIT { count } ]
> [ OFFSET start [ ROW | ROWS ] ]
> [ FETCH { FIRST | NEXT } [ count ] { ROW | ROWS } ONLY ]
> {code}
> Some new keywords(OFFSET,FETCH,ROW, ROWS,ONLY) are getting introduced so
> users might need to see that they are not using them as column name or
> something.
> WDYT, [~jamestaylor]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
