Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/154#discussion_r58555090
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
    @@ -138,6 +138,10 @@
         public final static String SYSTEM_SCHEMA_NAME = "SYSTEM";
         public final static byte[] SYSTEM_SCHEMA_NAME_BYTES = 
Bytes.toBytes(SYSTEM_SCHEMA_NAME);
         public final static String PHOENIX_METADATA = "table";
    +    public final static String SCAN_OFFSET = "OFFSET";
    --- End diff --
    
    Please change this to "_RowOffset" (to make is a little less general) and 
move to BaseScannerRegionObserver (this is where we keep all attributes we set 
on the Scan so we hopefully notice if we have a duplicate).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to