[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232740#comment-15232740
]
ASF GitHub Bot commented on PHOENIX-1311:
-----------------------------------------
Github user ankitsinghal commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r59075136
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java ---
@@ -265,12 +332,18 @@ public SingleTableColumnResolver(PhoenixConnection
connection, NamedTableNode ta
if (def.getColumnDefName().getFamilyName() != null) {
families.add(new
PColumnFamilyImpl(PNameFactory.newName(def.getColumnDefName().getFamilyName()),Collections.<PColumn>emptyList()));
}
- }
- Long scn = connection.getSCN();
- PTable theTable = new PTableImpl(connection.getTenantId(),
table.getName().getSchemaName(), table.getName().getTableName(), scn == null ?
HConstants.LATEST_TIMESTAMP : scn, families);
+ }
+ Long scn = connection.getSCN();
+ String schema = table.getName().getSchemaName();
+ if (connection.getSchema() != null) {
--- End diff --
The code in discussion will be used during **creation** of **mapped views**
only .. It will never be used anywhere else.
So when user provide table name without schema then connection schema
should be used if set and if user is providing tablename with schema then we
should ignore connection schema. I think this is how most of the databases work.
for eg:- connection schema is set to 'S' (`phoenix> USE 'S'`)
so , if user create mapped view,
`create view A.T(pk ...)`. //then this will map to A.T table only
`create view T(pk..)` // //then this will map to S.T table
And to map table to default schema (User can unset connection schema back
to null by using `USE DEFAULT`)
create view T(pk..) // //then this will map to T table
May be I'm missing something, would you mind giving some examples in terms
of sql statement.
> HBase namespaces surfaced in phoenix
> ------------------------------------
>
> Key: PHOENIX-1311
> URL: https://issues.apache.org/jira/browse/PHOENIX-1311
> Project: Phoenix
> Issue Type: New Feature
> Reporter: nicolas maillard
> Assignee: Ankit Singhal
> Priority: Minor
> Fix For: 4.8.0
>
> Attachments: PHOENIX-1311.docx, PHOENIX-1311_v1.patch,
> PHOENIX-1311_v2.patch, PHOENIX-1311_wip.patch, PHOENIX-1311_wip_2.patch
>
>
> Hbase (HBASE-8015) has the concept of namespaces in the form of
> myNamespace:MyTable it would be great if Phoenix leveraged this feature to
> give a database like feature on top of the table.
> Maybe to stay close to Hbase it could also be a create DB:Table...
> or DB.Table which is a more standard annotation?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
