Github user ankitsinghal commented on the pull request:

    https://github.com/apache/phoenix/pull/153#issuecomment-209296286
  
    @samarthjain 
    
    > Will the table T be created in the namespace S? If the feature is 
disabled, it shouldn't be. Would you mind adding a test for this if it hasn't 
been already?
    
    Yes, table T will not be created in namespace S if isNamespaceMapped is 
disabled. Test is there in CreateTableIT#testCreateTable
    
    > Also, how about if we do a CREATE TABLE SCHEMA.TABLENAME with the feature 
on. Does it end up creating the namespace named SCHEMA first and then maps the 
table to that namespace
    
    If features is on and SCHEMA is not already present it will fail with 
SchemaNotFoundException. User has to create a schema first and then he can 
create a table if the config is set to true.
    but when config is set to false, it will create a table with name 
SCHEMA.TABLENAME in default namespace without throwing any 
SchemaNotFoundException.
    I have added a test(CreateTableIT#testCreateTableWithoutSchema) in the 
latest commit for the same.
    
    
    
    
    
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to