[
https://issues.apache.org/jira/browse/PHOENIX-2862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260612#comment-15260612
]
Hadoop QA commented on PHOENIX-2862:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12801057/PHOENIX-2862.patch
against master branch at commit 5574811ddfe24a7f78ec875d3591439c32433f47.
ATTACHMENT ID: 12801057
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
27 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 4 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ conn.createStatement().execute("CREATE VIEW v (col VARCHAR) AS
SELECT * FROM " + phoenixFullTableName);
+ logger.error("Old client is not compatible when system tables are
upgraded to map to namespace");
+ "Old client is not compatible when system tables
are upgraded to map to namespace",
+ "Cannot create schema because config " +
QueryServices.IS_NAMESPACE_MAPPING_ENABLED
+ + " for enabling name space mapping isn't
enabled."), INCONSISTENET_NAMESPACE_MAPPING_PROPERTIES(
+ public static final int MIN_NAMESPACE_MAPPED_PHOENIX_VERSION =
VersionUtil.encodeVersion("4", "8", "0");
+
checkClientServerCompatibility(SchemaUtil.getPhysicalName(SYSTEM_CATALOG_NAME_BYTES,
this.getProps()).getName());
+
checkClientServerCompatibility(SchemaUtil.getPhysicalName(SYSTEM_CATALOG_NAME_BYTES,
this.getProps()).getName());
+ isSystemNamespaceMappingEnabled |=
MetaDataUtil.decodeSystemNamespaceMappingEnabled(version);
+ if (isSystemNamespaceMappingEnabled !=
SchemaUtil.isNamespaceMappingEnabled(PTableType.SYSTEM,
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-flume/target/failsafe-reports/TEST-org.apache.phoenix.flume.PhoenixSinkIT
./phoenix-flume/target/failsafe-reports/TEST-org.apache.phoenix.flume.RegexEventSerializerIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/311//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/311//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/311//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/311//console
This message is automatically generated.
> Do client server compatibility checks before upgrading system tables
> --------------------------------------------------------------------
>
> Key: PHOENIX-2862
> URL: https://issues.apache.org/jira/browse/PHOENIX-2862
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Ankit Singhal
> Assignee: Ankit Singhal
> Fix For: 4.8.0
>
> Attachments: PHOENIX-2862.patch
>
>
> currently , we allow upgrade of system tables to map to system namespace by
> enabling "phoenix.schema.mapSystemTablesToNamespace" config (conjuction with
> "phoenix.connection.isNamespaceMappingEnabled")
> but we need to ensure following things whenever client connects with above
> config:-
> 1. Server should be upgraded and check consistency of these properties
> between client and server.
> 2. If above property does not exists but system:catalog exists, we should not
> start creating system.catalog.
> 3. if old client connects, it should not create system.catalog again ignoring
> the upgrade and start using it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
