[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270567#comment-15270567
]
Hadoop QA commented on PHOENIX-2628:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12802167/PHOENIX-2628_v10.patch
against master branch at commit 99713a61cd758a8486f1b49225c5e1c6766dc7b9.
ATTACHMENT ID: 12802167
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
29 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 4 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ ScanUtil.setLocalIndexAttributes(scan, 0,
HConstants.EMPTY_BYTE_ARRAY, HConstants.EMPTY_BYTE_ARRAY, scan.getStartRow(),
scan.getStopRow());
+ String[] strings =
{"a","b","c","d","e","f","g","h","i","j","k","l","m","n","o","p","q","r","s","t","u","v","w","x","y","z"};
+ HBaseAdmin admin = driver.getConnectionQueryServices(getUrl(),
TestUtil.TEST_PROPERTIES).getAdmin();
+ if(admin.tableExists(localIndex?
MetaDataUtil.getLocalIndexTableName(tableName): indexName)) {
+ admin.disableTable(localIndex?
MetaDataUtil.getLocalIndexTableName(tableName): indexName);
+ admin.deleteTable(localIndex?
MetaDataUtil.getLocalIndexTableName(tableName): indexName);
+ private void createTableAndLoadData(Connection conn1, String[] strings,
boolean isReverse) throws SQLException {
+ "CREATE " + (localIndex ? "LOCAL" : "")+" INDEX " + indexName + "
ON " + tableName + "(v1"+(isReverse?" DESC":"")+") include (k3)");
+ HBaseAdmin admin = driver.getConnectionQueryServices(getUrl(),
TestUtil.TEST_PROPERTIES).getAdmin();
+ conn1.createStatement().execute("CREATE
"+(localIndex?"LOCAL":"")+" INDEX " + indexName + " ON " + tableName + "(v1)" +
(localIndex?"":" SPLIT ON ('e')"));
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.QueryDatabaseMetaDataIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/321//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/321//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/321//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/321//console
This message is automatically generated.
> Ensure split when iterating through results handled correctly
> -------------------------------------------------------------
>
> Key: PHOENIX-2628
> URL: https://issues.apache.org/jira/browse/PHOENIX-2628
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Rajeshbabu Chintaguntla
> Fix For: 4.8.0
>
> Attachments: PHOENIX-2628-wip.patch, PHOENIX-2628.patch,
> PHOENIX-2628_v10.patch, PHOENIX-2628_v7.patch, PHOENIX-2628_v8.patch,
> PHOENIX-2628_v9.patch
>
>
> We should start with a test case to ensure this works correctly, both for
> scans and aggregates.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
