[ https://issues.apache.org/jira/browse/PHOENIX-2897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283019#comment-15283019 ]
Enis Soztutar commented on PHOENIX-2897: ---------------------------------------- This is the the diff between what is run versus the classes with IT and Test in their name (excluding Base and Abstract classes): {code} < ClientManagedTimeTest 67d46 < ConnectionQueryServicesTestImpl 74d52 < CoveredIndexCodecForTesting 93d70 < DropIndexDuringUpsertIT 100d76 < End2EndTestDriver 121,122d96 128d101 < HiveTestUtil 135d107 < IndexHandlerIT 140,141d111 < IndexTestUtil < IndexTestingUtils 172d141 < MinVersionTestRunner 184d152 < NeedsOwnMiniClusterTest 225d192 < PhoenixTestDriver 253d219 < QueryServicesTestImpl 263d228 < ReadWriteKeyValuesWithCodecIT 272d236 < ReserveNSequenceTestIT 275,277d238 286a248 > RowKeyOrderedAggregateResultIteratorTest 336d297 373d333 < TestPhoenixIndexRpcSchedulerFactory 377d336 < TestUtil 385d343 < TracingTestUtil {code} A couple of things: - DropIndexDuringUpsertIT is an abstract test with no implementation that extends it. It has a single test that is excluded. - IndexHandlerIT seems it is testing the RPC priority. It fails with NPE. - ReadWriteKeyValuesWithCodecIT and ReserveNSequenceTestIT - Two classes doing the same thing: IndexTestUtil and IndexTestingUtils. - We should use {{-DfailIfNoTests=false}}, otherwise we cannot run a subset of tests from modules. - In HBase, we have a unit test to cover this exact case, where a new test comes in without a Category annotation, we fail the unit test. See TestCheckTestClasses. > Some ITs are not run > --------------------- > > Key: PHOENIX-2897 > URL: https://issues.apache.org/jira/browse/PHOENIX-2897 > Project: Phoenix > Issue Type: Bug > Reporter: Enis Soztutar > Assignee: Enis Soztutar > Priority: Critical > Fix For: 4.8.0 > > > I've noticed that some of the IT tests are not run from the mvn verify > command. These are tests that are not marked with an explicit {{@Category}} > or does not extend the base test classes. > Some example ones are: > {code} > IndexHandlerIT > ReadWriteKeyValuesWithCodecIT > {code} > See the lack of these tests in > https://builds.apache.org/view/All/job/phoenix-master/1223/consoleFull -- This message was sent by Atlassian JIRA (v6.3.4#6332)