[
https://issues.apache.org/jira/browse/PHOENIX-2865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15306293#comment-15306293
]
Hadoop QA commented on PHOENIX-2865:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12806922/PHOENIX-2865_v1.patch
against master branch at commit 95c004112bae47624f4764154e90cc36a54827f1.
ATTACHMENT ID: 12806922
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
31 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 4 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ conn.createStatement().execute("UPDATE STATISTICS " + tableName +
" SET \"phoenix.stats.guidepost.width\"=100");
+ conn.createStatement().execute("UPDATE STATISTICS "+TABLE_NAME+"
SET \"phoenix.stats.guidepost.width\"=20");
+ List<KeyRange> splits =
stmt.unwrap(PhoenixPreparedStatement.class).getQueryPlan().getSplits();
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/373//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/373//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/373//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/373//console
This message is automatically generated.
> We should not use GuidePosts when we are running query in serial
> ----------------------------------------------------------------
>
> Key: PHOENIX-2865
> URL: https://issues.apache.org/jira/browse/PHOENIX-2865
> Project: Phoenix
> Issue Type: Bug
> Reporter: Ankit Singhal
> Assignee: Ankit Singhal
> Priority: Minor
> Attachments: PHOENIX-2865.patch, PHOENIX-2865_v1.patch
>
>
> Although it conflict a little with the work done in PHOENIX-2724 ,but I think
> , query with serial Hint or serial query (non-orderby query with limit/offset
> on non-salted/non-local index table) should not use guidePosts as it is
> unnecessary.
> [~jamestaylor]/[~samarthjain], WDYT?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
