[
https://issues.apache.org/jira/browse/PHOENIX-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323068#comment-15323068
]
Ankit Singhal commented on PHOENIX-2901:
----------------------------------------
bq. I am not convinced this is the right thing to do here. Shouldn't tenantId
be a param here?
We call deleteViewIndexSequences when we drop a multi-tenant table and and we
want all the sequences created for views indexes(with tenantId or not) should
be deleted. so tenantId is not required here.
bq. You would also want to test ViewIndexIT.testDeleteViewIndexSequences with
an without name space mapping enabled.
ViewIndexIT is a parameterized class which runs with namespaceMapping enabled
and disabled.
bq. Also, I don't see tests around tenant views, indexes, index sequences, etc
as I had suggested earlier (unless I am missing them).
I'm not sure if you are looking at the latest patch, but
TenantSpecificViewIndexIT.testMultiCFViewIndexWithNamespaceMapping() &
TenantSpecificViewIndexIT.testMultiCFViewIndex() are already there.
Thanks [~samarth.j...@gmail.com] for looking into this. let me know if you need
any more info.
> If namespaces are enabled, check for existence of schema when sequence created
> ------------------------------------------------------------------------------
>
> Key: PHOENIX-2901
> URL: https://issues.apache.org/jira/browse/PHOENIX-2901
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.8.0
> Reporter: James Taylor
> Assignee: Ankit Singhal
> Fix For: 4.8.0
>
> Attachments: PHOENIX-2901.patch, PHOENIX-2901_v2.patch,
> PHOENIX-2901_withMoreTestCases.patch
>
>
> If namespaces are enabled, we should check for the existence of the sequence
> schema before creating the sequence. There are some sequences that are
> generated by Phoenix to manage indexes over views which auto generate a
> schema name. Perhaps it'd be better if those used the SYSTEM schema instead
> and prepended the sequence name with the previous schema name to ensure
> uniqueness.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
