[
https://issues.apache.org/jira/browse/PHOENIX-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15326558#comment-15326558
]
James Taylor commented on PHOENIX-2965:
---------------------------------------
Looks good. Two small requests:
- Add a TODO here for PHOENIX-2989 to allow optimization under all cases where
possible
{code}
+ if (statement.getHint().hasHint(Hint.RANGE_SCAN) ||
+ statement.getHaving() != null ||
+ !statement.getOrderBy().isEmpty()) {
+ return GroupBy.UNGROUPED_GROUP_BY;
+ }
{code}
- Add a couple of negative tests in QueryCompilerTest for the cases you found
regarding ORDER BY to prevent any future regressions:
{code}
select /*+ RANGE_SCAN */ count(distinct pk1) from pv order by pk1;
select count(distinct pk1) from pv order by pk1
{code}
You can copy/paste QueryCompilerTest.testSelectDistinctAndAll() for this.
> Use DistinctPrefixFilter logic for COUNT(DISTINCT ...) and COUNT(...) GROUP BY
> ------------------------------------------------------------------------------
>
> Key: PHOENIX-2965
> URL: https://issues.apache.org/jira/browse/PHOENIX-2965
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 4.8.0
>
> Attachments: 2965-v10.txt, 2965-v11.txt, 2965-v12.txt, 2965-v13.txt,
> 2965-v2.txt, 2965-v3.txt, 2965-v4.txt, 2965-v5.txt, 2965-v6.txt, 2965-v7.txt,
> 2965-v8.txt, 2965-v9.txt, 2965.txt, PHOENIX-2965_wip.patch
>
>
> Parent uses skip scanning to optimize DISTINCT and certain GROUP BY
> operations along the row key.
> COUNT queries are optimized differently, could be sped up significantly as
> well.
> [~giacomotaylor], I might need to help into where COUNT(DISTINCT) queries are
> planned and optimized.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
