[
https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15338874#comment-15338874
]
Hadoop QA commented on PHOENIX-2931:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12811739/PHOENIX-2931-v1.patch
against master branch at commit d2b13475032f863313d4b32894ade05d1f1669c5.
ATTACHMENT ID: 12811739
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
34 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 7 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+$[optional_sql_file] \nExample:
1. sqlline.py
2. sqlline.py localhost:2181:/hbase
3. sqlline.py \
+ usageError("Connection string to HBase must be supplied before
input files", options);
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.phoenix.jdbc.PhoenixEmbeddedDriverTest
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/401//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/401//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/401//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/401//console
This message is automatically generated.
> Phoenix client asks users to provide configs in cli that are present on the
> machine in hbase conf
> -------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-2931
> URL: https://issues.apache.org/jira/browse/PHOENIX-2931
> Project: Phoenix
> Issue Type: Bug
> Reporter: Alicia Ying Shu
> Assignee: Alicia Ying Shu
> Priority: Minor
> Fix For: 4.8.0
>
> Attachments: PHOENIX-2931-v1.patch, PHOENIX-2931.patch
>
>
> Users had complaints on running commands like
> {code}
> phoenix-sqlline
> pre-prod-poc-2.novalocal,pre-prod-poc-10.novalocal,pre-prod-poc-1.novalocal:/hbase-unsecure
> service-logs.sql
> {code}
> However the zookeeper quorum and the port are available in hbase configs.
> Phoenix should read these configs from the system instead of having the user
> supply them every time.
> What we can do is to introduce a keyword "default". If it is specified,
> default zookeeper quorum and port will be taken from hbase configs.
> Otherwise, users can specify their own.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
