[
https://issues.apache.org/jira/browse/PHOENIX-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15345376#comment-15345376
]
Josh Elser commented on PHOENIX-3020:
-------------------------------------
bq. Once we shade jersey, shading plugin also shading all related records in
META-INF/services and it becomes used by MR's jetty. I will remove it (actually
thought to keep it to remember that we are not shading it and possible we will
need to address it in the future. Like removing services file if we do not use
it)
Gotcha. So, someone is calling this from a jar other than our shaded client jar
(and is looking for the non-shaded packages)? I'll admit, I don't know what
you're referring to with "runJar". Is that somethign in Phoenix? A Hadoop/YARN
thing for submitting a job?
bq. our LICENSE/NOTICE files are copying to the root of the jar. Actually some
clean up is required for this mess of licenses from dependencies, but at the
moment there are no changes between how we handling them now and how we did it
before shading stuff, so it can/should be done in a separate jira later.
Yeah, tbqh, I'm a little fearful of rc0 and verifying the ASF licensing
requirements...
bq. can you please review this, Is this how other projects are handling or we
have not experience this elsewhere yet?
Most projects don't have a good story here AFAIK :)
{noformat}
+ <!--<relocation>-->
+ <!--<pattern>com.sun.jersey</pattern>-->
+
<!--<shadedPattern>${shaded.package}.com.sun.jersey</shadedPattern>-->
+ <!--</relocation>-->
{noformat}
Looks like you forgot to remove this commented block in your 2nd patch.
Otherwise, if you're having success with this, +1 from me.
> Bulk load tool is not working with new jars
> -------------------------------------------
>
> Key: PHOENIX-3020
> URL: https://issues.apache.org/jira/browse/PHOENIX-3020
> Project: Phoenix
> Issue Type: Bug
> Reporter: Ankit Singhal
> Assignee: Sergey Soldatov
> Priority: Blocker
> Attachments: PHOENIX-3020-2.patch, PHOENIX-3020.patch
>
>
> [~rajeshbabu] and [~sergey.soldatov] has identified an issue related to bulk
> load tool with latest jars
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
