[ 
https://issues.apache.org/jira/browse/PHOENIX-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353063#comment-15353063
 ] 

Loknath Priyatham Teja Singamsetty  commented on PHOENIX-2966:
--------------------------------------------------------------

[~jamestaylor][~samarthjain] 

a) Borrowed the query from PhoenixMRJobSubmitter CANDIDATE_INDEX_INFO_QUERY 
which is also missing the column_family and async_created_date. Will be 
correcting the query and adding the required columns for both usecases and 
access it from some constants file (common location) instead of defining at two 
places.
b) The changes to PhoenixEmbeddedDriver.java is minor typo correction of name 
from "QUARUM" to "QUORUM" for zookeeper related variable name.
c) On the unit test front, I don't see any unit test for BuildIndexScheduleTask 
which is another timer task inside the MetaDataRegionObserver.java. However, 
will see if i can add one or cover as part of workflow or ftest.



> Implement mechanism to build async indexes when running locally
> ---------------------------------------------------------------
>
>                 Key: PHOENIX-2966
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2966
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>            Assignee: Loknath Priyatham Teja Singamsetty 
>             Fix For: 4.8.0
>
>         Attachments: phoenix-2966.patch
>
>
> For local, non distributed environments, we need to build indexes that were 
> build asynchronously.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to