[
https://issues.apache.org/jira/browse/PHOENIX-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankit Singhal updated PHOENIX-2999:
-----------------------------------
Attachment: PHOENIX-2999_v6.patch
Thanks [~jamestaylor] for the review.
bq. You don't need to store every tenantID in a Map here.
Updated patch to use result set for iterating views for a table.
bq. Not sure I understand this change, but it looks suspect. Was there a bug
here before?
Earlier , I was updating all the links with a single query but with latest
changes , I'm doing one by one only and that's why LINK queries are updated to
include tenantId, tableschema and tablename in filter.
bq. In the updateLink upgrade code, are you upgrading the link row for every
view? If that's the case, you perhaps can just set the TABLE_TYPE column there
and then you won't need to check for TABLE_TYPE IS NULL in the GET_VIEWS_QUERY.
If not, not a big deal.
Firstly , I'm getting views and then updating the link for the same so it won't
help in the query for getting views. And, still I'm keeping table_type as NULL
for views physical link to avoid any backward compatible issues, probably we
can change in next release.
> Upgrading Multi-tenant table to map with namespace using upgradeUtil
> --------------------------------------------------------------------
>
> Key: PHOENIX-2999
> URL: https://issues.apache.org/jira/browse/PHOENIX-2999
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.8.0
> Reporter: Ankit Singhal
> Assignee: Ankit Singhal
> Priority: Critical
> Fix For: 4.8.0
>
> Attachments: PHOENIX-2999.patch, PHOENIX-2999_v1.patch,
> PHOENIX-2999_v2.patch, PHOENIX-2999_v3.patch, PHOENIX-2999_v4.patch,
> PHOENIX-2999_v5.patch, PHOENIX-2999_v6.patch
>
>
> currently upgradeUtil doesn't handle multi-tenant table with tenant views
> properly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
