[ 
https://issues.apache.org/jira/browse/PHOENIX-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lars Hofhansl updated PHOENIX-3070:
-----------------------------------
    Description: 
I see {{UUID.randomUUID()}} used all over Phoenix a lot.
{{randomUUID}} uses {{SecureRandom}} internally, which - on my machine - takes 
almost 3ms, and that is _per UUID_!

I don't think we need a UUIDs from a cryptographically sound random number 
generator.

We could do {{new UUID(random.nextLong(), random.nextLong())}}, which takes 
0.06ms (60us), or even better: {{new 
UUID(ThreadLocalRandom.current().nextLong(), random.nextLong())}}, which takes 
less than 0.004ms (4us) on my box.


  was:
I see {{UUID.randomUUID()}} used all over Phoenix a lot.
{{randomUUID}} uses {{SecureRandom}} internally, which - on my machine - takes 
almost 3ms, and that is _per UUID_!

I don't think we need a UUIDs from a cryptographically sound random number 
generator.

We could do {{new UUID(random.nextLong(), random.nextLong())}}, which takes 
0.06ms (60us), or even better: {{new 
UUID(ThreadLocalRandom.current().nextLong(), random.nextLong())}}, which takes 
less than 0.006ms (6us) on my box.



> Unnecessary use of UUID.randomUUID()
> ------------------------------------
>
>                 Key: PHOENIX-3070
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3070
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>
> I see {{UUID.randomUUID()}} used all over Phoenix a lot.
> {{randomUUID}} uses {{SecureRandom}} internally, which - on my machine - 
> takes almost 3ms, and that is _per UUID_!
> I don't think we need a UUIDs from a cryptographically sound random number 
> generator.
> We could do {{new UUID(random.nextLong(), random.nextLong())}}, which takes 
> 0.06ms (60us), or even better: {{new 
> UUID(ThreadLocalRandom.current().nextLong(), random.nextLong())}}, which 
> takes less than 0.004ms (4us) on my box.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to