[ https://issues.apache.org/jira/browse/PHOENIX-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383345#comment-15383345 ]
Hudson commented on PHOENIX-3070: --------------------------------- SUCCESS: Integrated in Phoenix-master #1329 (See [https://builds.apache.org/job/Phoenix-master/1329/]) PHOENIX-3070 Unnecessary use of UUID.randomUUID(). (larsh: rev 6a0afa4fa45bce497275eda76fa3c6e663ee9979) * phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java > Unnecessary use of UUID.randomUUID() > ------------------------------------ > > Key: PHOENIX-3070 > URL: https://issues.apache.org/jira/browse/PHOENIX-3070 > Project: Phoenix > Issue Type: Bug > Reporter: Lars Hofhansl > Assignee: Lars Hofhansl > Priority: Minor > Fix For: 4.8.1 > > Attachments: 3070.txt > > > I see {{UUID.randomUUID()}} used all over Phoenix a lot. > {{randomUUID}} uses {{SecureRandom}} internally, which - on my machine - > takes almost 3ms, and that is _per UUID_! > I don't think we need a UUIDs from a cryptographically sound random number > generator. > We could do {{new UUID(random.nextLong(), random.nextLong())}}, which takes > 0.06ms (60us), or even better: {{new > UUID(ThreadLocalRandom.current().nextLong(), > ThreadLocalRandom.current().nextLong())}}, which takes less than 0.004ms > (4us) on my box. -- This message was sent by Atlassian JIRA (v6.3.4#6332)