Github user btbytes commented on the issue:

    https://github.com/apache/phoenix/pull/186
  
    I'd definitely love add unit tests by breaking up the functionality into 
testable parts.  I have couple of concerns:
    
    1. the use of globals, esp in the common module -- `phoenix_utils`. If we 
manage to isolate modules cleanly, testing will that much more meaningful
    2. quite a bit of this script is to poke the environment .. which is I/O. 
Unit testing may not yield much. But, i'll take a fresh look. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to