[
https://issues.apache.org/jira/browse/PHOENIX-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403665#comment-15403665
]
Hadoop QA commented on PHOENIX-3128:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12821525/PHOENIX-3128_v7.patch
against master branch at commit 545cc1c025ec56ef174f117f8d96212457f96363.
ATTACHMENT ID: 12821525
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
34 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ long ts = conn.unwrap(PhoenixConnection.class).getTable(new
PTableKey(null,fullTableName)).getTimeStamp();
+ private void assertNoIndexDeletes(Connection conn, long minTimestamp,
String fullIndexName) throws IOException, SQLException {
+ private Iterator<Pair<byte[],List<Mutation>>> addRowMutations(final
TableRef tableRef, final Map<ImmutableBytesPtr, RowMutationState> values,
+ // TODO: change to
IndexMaintainer.enabledGlobalIndexIterator() when local indexes generate
+
IndexMaintainer.nonDisabledIndexIterator(table.getIndexes().iterator()) :
+ public static void addMutation(Map<ImmutableBytesPtr, MultiMutation>
mutations, ImmutableBytesPtr row, Mutation m) {
+ throw new NullPointerException("Expected to find transaction in
metadata for " + env.getRegionInfo().getTable().getNameAsString());
+ processRollback(env, indexMetaData, txRollbackAttribute,
currentScanner, tx, mutableColumns, indexUpdates, mutations);
+ processMutation(env, indexMetaData, txRollbackAttribute,
currentScanner, tx, mutableColumns, indexUpdates, mutations,
findPriorValueMutations);
+ if (cell.getTypeByte() != KeyValue.Type.Put.getCode() ||
TransactionUtil.isDelete(cell)) {
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/490//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/490//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/490//console
This message is automatically generated.
> Remove extraneous operations during upsert with local immutable index
> ---------------------------------------------------------------------
>
> Key: PHOENIX-3128
> URL: https://issues.apache.org/jira/browse/PHOENIX-3128
> Project: Phoenix
> Issue Type: Bug
> Reporter: Junegunn Choi
> Assignee: Junegunn Choi
> Fix For: 4.8.1
>
> Attachments: PHOENIX-3128.patch, PHOENIX-3128_v2.patch,
> PHOENIX-3128_v3.patch, PHOENIX-3128_v4.patch, PHOENIX-3128_v5.patch,
> PHOENIX-3128_v6.patch, PHOENIX-3128_v7.patch, PHOENIX-3128_wip.patch
>
>
> Upsert to a table with a local immutable index is supposed to be more
> efficient than to a table with a local mutable index, but it's actually
> slower (in our environment by 30%) due to extraneous operations involved.
> The problem is twofold:
> 1. Client unnecessarily prepares and sends index update.
> 2. Index cleanup is done regardless of the immutability of the table.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
