[ 
https://issues.apache.org/jira/browse/PHOENIX-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15414023#comment-15414023
 ] 

James Taylor commented on PHOENIX-2835:
---------------------------------------

Looking good, [~an...@apache.org]. Here's some feedback:
- How about adding an example of OFFSET usage and a description here?
{code}
--- phoenix-docs/src/docsrc/help/phoenix.csv    (revision 1755501)
+++ phoenix-docs/src/docsrc/help/phoenix.csv    (working copy)
@@ -1,7 +1,7 @@
 "SECTION","TOPIC","SYNTAX","TEXT","EXAMPLE"
 "Commands","SELECT","
 selectStatement [ { UNION ALL selectStatement [...] } ]
-[ ORDER BY order [,...] ] [ LIMIT {bindParameter | number} ]
+[ ORDER BY order [,...] ] [ LIMIT {bindParameter | number} ] [ OFFSET 
{bindParameter | number} [ ROW | ROWS ] ] [ FETCH { FIRST | NEXT } 
{bindParameter | number} { ROW | ROWS } ONLY ]
 ","
 Selects data from one or more tables.
 UNION ALL combines rows from multiple select statements.
@@ -286,6 +286,37 @@
 UPDATE STATISTICS my_table SET phoenix.stats.guidepost.width=50000000
 "
{code}
- Can you include info on the config param you need to set to enable these 
commands?
{code}
+"Commands","CREATE SCHEMA","
+CREATE SCHEMA [IF NOT EXISTS] schemaName
+","
+creates a schema and corresponding name-space in hbase.
+","
+CREATE SCHEMA IF NOT EXISTS my_schema
+CREATE SCHEMA my_schema
+"
+
{code}
- I don't see anything on upgrade utility here - maybe it's in a different 
patch?

> Add documentation for schema constructs and upgrade utility
> -----------------------------------------------------------
>
>                 Key: PHOENIX-2835
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2835
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>            Priority: Minor
>             Fix For: 4.9.0
>
>         Attachments: PHOENIX-2835.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to