Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74304816
--- Diff: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
---
@@ -1052,16 +1057,20 @@ private static void deletePriorSequences(long ts,
Connection globalConn) throws
}
rs.close();
}
-
+
protected static void initSumDoubleValues(byte[][] splits, String url)
throws Exception {
- ensureTableCreated(url, "SumDoubleTest", splits);
+ initSumDoubleValues("SumDoubleTest", splits, url);
+ }
+
+ protected static void initSumDoubleValues(String tableName, byte[][]
splits, String url) throws Exception {
+ ensureTableCreated(url, tableName, "SumDoubleTest", splits);
--- End diff --
Minor nit: Define a static constant for SumDoubleTest like other table ddl
types.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
