[ 
https://issues.apache.org/jira/browse/PHOENIX-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419373#comment-15419373
 ] 

ASF GitHub Bot commented on PHOENIX-3036:
-----------------------------------------

Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/189#discussion_r74652145
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/LocalIndexIT.java ---
    @@ -76,24 +76,18 @@
     import com.google.common.collect.Maps;
     
     @RunWith(Parameterized.class)
    -public class LocalIndexIT extends BaseHBaseManagedTimeIT {
    -
    -    private String schemaName="TEST";
    +public class LocalIndexIT extends BaseHBaseManagedTimeTableReuseIT {
         private boolean isNamespaceMapped;
    -    private String tableName = schemaName + ".T";
    -    private String indexTableName = schemaName + ".I";
    -    private String indexName = "I";
    -    private String indexPhysicalTableName;
    -    private TableName physicalTableName;
    +    String schemaName="TEST";
     
         public LocalIndexIT(boolean isNamespaceMapped) {
             this.isNamespaceMapped = isNamespaceMapped;
    -        this.physicalTableName = 
SchemaUtil.getPhysicalTableName(tableName.getBytes(), isNamespaceMapped);
    -        this.indexPhysicalTableName = 
this.physicalTableName.getNameAsString();
    +        //this.physicalTableName = 
SchemaUtil.getPhysicalTableName(tableName.getBytes(), isNamespaceMapped);
    --- End diff --
    
    Remove commented code.


> Modify phoenix IT tests to extend BaseHBaseManagedTimeTableReuseIT
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-3036
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3036
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Samarth Jain
>            Assignee: prakul agarwal
>             Fix For: 4.9.0
>
>         Attachments: PHOENIX-3036.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to