[ https://issues.apache.org/jira/browse/PHOENIX-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15433608#comment-15433608 ]
Hadoop QA commented on PHOENIX-1751: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12825121/PHOENIX-1751_v4.patch against master branch at commit b36bb31fe42cb7bf5b6de5bfab63bcad424998a4. ATTACHMENT ID: 12825121 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 34 warning messages. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + setUpTestDriver(new ReadOnlyProps(serverProps.entrySet().iterator()), new ReadOnlyProps(clientProps.entrySet().iterator())); + ResultSet rs = conn.createStatement().executeQuery("select count(*) from " + TABLE_NAME); + if (SLEEP_NOW && c.getEnvironment().getRegion().getRegionInfo().getTable().getNameAsString().equals(TABLE_NAME)) { + public RegionScannerHolder(ObserverContext<RegionCoprocessorEnvironment> c, Scan scan, final RegionScanner scanner) { + // and region servers to crash. See https://issues.apache.org/jira/browse/PHOENIX-1596 + ServerUtil.throwIOException(c.getEnvironment().getRegionInfo().getRegionNameAsString(), t); + public boolean next(List<Cell> result, ScannerContext scannerContext) throws IOException { + public boolean nextRaw(List<Cell> result, ScannerContext scannerContext) throws IOException { {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/530//testReport/ Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/530//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/530//console This message is automatically generated. > Perform aggregations, sorting, etc, in the preScannerNext instead of > postScannerOpen > ------------------------------------------------------------------------------------ > > Key: PHOENIX-1751 > URL: https://issues.apache.org/jira/browse/PHOENIX-1751 > Project: Phoenix > Issue Type: Bug > Reporter: Lars Hofhansl > Assignee: Lars Hofhansl > Attachments: 1751-WIP-v2.txt, 1751-WIP-v2b.patch, 1751-WIP.txt, > PHOENIX-1751-v2c.patch, PHOENIX-1751.patch, PHOENIX-1751_v3.patch, > PHOENIX-1751_v4.patch > > > HBase retains a lease for every scanner. Then lease expires the scan will no > longer (be allowed to) work. The leases guard against the client going away, > and allow cleaning up resources if that happens. > At various points HBase "suspends" the lease while the region server are > working on behalf of this scanner, so that the lease won't expire even though > the server is working on it. > HBase does that during the scanning process. Crucially it suspends the leaser > after the scanner is opened, before next() is issued on it. > The outcome of all this is that Phoenix executes aggregates, sorts, etc, with > the lease in place, and hence if these take a bit the lease can expire even > though the server was working on it. > Phoenix should do this work in preScannerNext, being careful that the > precalculation is only performed once. > I'll attach a sample patch soon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)