[ https://issues.apache.org/jira/browse/PHOENIX-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447382#comment-15447382 ]
Hadoop QA commented on PHOENIX-3201: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12826085/PHOENIX-3201.patch against master branch at commit 14dab2f40df0d09f48f9cabbaea897009f635914. ATTACHMENT ID: 12826085 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 34 warning messages. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + String ddl = "CREATE TABLE IF NOT EXISTS T1 (k1 INTEGER NOT NULL, dates DATE, timestamps TIMESTAMP, times TIME CONSTRAINT pk PRIMARY KEY (k1))"; + String dml = "UPSERT INTO T1 VALUES (1, TO_DATE('2012-03-08 11:01:10'), TO_TIMESTAMP('2013-06-16 12:02:20'), TO_TIME('2014-09-23 13:03:30'))"; + dml = "UPSERT INTO T1 VALUES (2, TO_DATE('2013-04-09 11:02:10'), TO_TIMESTAMP('2014-05-18 12:03:20'), TO_TIME('2015-06-27 13:04:30'))"; + ResultSet rs = conn.createStatement().executeQuery("SELECT k1, DAYOFWEEK(dates), DAYOFWEEK(timestamps) FROM T1 where DAYOFWEEK(times)=6"); + String ddl = "CREATE TABLE IF NOT EXISTS T1 (k1 INTEGER NOT NULL, dates DATE, timestamps TIMESTAMP, times TIME CONSTRAINT pk PRIMARY KEY (k1))"; + String dml = "UPSERT INTO T1 VALUES (1, TO_DATE('2012-03-01 11:01:10'), TO_TIMESTAMP('2013-02-01 12:02:20'), TO_TIME('2014-01-15 13:03:30'))"; + dml = "UPSERT INTO T1 VALUES (2, TO_DATE('2013-04-09 11:02:10'), TO_TIMESTAMP('2014-05-18 12:03:20'), TO_TIME('2015-06-27 13:04:30'))"; + ResultSet rs = conn.createStatement().executeQuery("SELECT k1, DAYOFYEAR(dates), DAYOFYEAR(timestamps) FROM T1 where DAYOFYEAR(times)=15"); {color:red}-1 core tests{color}. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/545//testReport/ Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/545//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/545//console This message is automatically generated. > Implement DAYOFWEEK and DAYOFYEAR built-in functions > ---------------------------------------------------- > > Key: PHOENIX-3201 > URL: https://issues.apache.org/jira/browse/PHOENIX-3201 > Project: Phoenix > Issue Type: Bug > Reporter: James Taylor > Assignee: prakul agarwal > Labels: newbie > Fix For: 4.9.0 > > Attachments: PHOENIX-3201.patch > > > DAYOFWEEK() as documented here: > https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005645 > DAYOFYEAR() as documented here: > https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005676 -- This message was sent by Atlassian JIRA (v6.3.4#6332)