[ 
https://issues.apache.org/jira/browse/PHOENIX-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15459421#comment-15459421
 ] 

Kevin Liew edited comment on PHOENIX-2946 at 9/2/16 8:16 PM:
-------------------------------------------------------------

Sure, I increased the test coverage. 

After applying your patch, signed date-timestamp comparison is fixed. But we 
get test failures when comparing signed to unsigned types.

Signed date-time type are bytes-comparable to other signed date-time types, but 
not to unsigned date-time types. Should they be castable or coercible?


was (Author: kliew):
Sure, I increased the test coverage. 

After applying your patch, signed date-timestamp comparison if fixed. But we 
get test failures when comparing signed to unsigned types.

Signed date-time type are bytes-comparable to other signed date-time types, but 
not to unsigned date-time types. Should they be castable or coercible?

> Projected comparison between date and timestamp columns always returns true
> ---------------------------------------------------------------------------
>
>                 Key: PHOENIX-2946
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2946
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.6.0, 4.8.0
>            Reporter: Kevin Liew
>            Assignee: Kevin Liew
>            Priority: Minor
>              Labels: comparison, date, timestamp
>             Fix For: 4.9.0, 4.8.1
>
>         Attachments: PHOENIX-2946_v2.patch
>
>
> {code}
> 0: jdbc:phoenix:thin:url=http://localhost:876> create table test (dateCol 
> DATE primary key, timestampCol TIMESTAMP);
> No rows affected (2.559 seconds)
> 0: jdbc:phoenix:thin:url=http://localhost:876> upsert into test values 
> (TO_DATE('1990-01-01'), NOW());
> 1 row affected (0.255 seconds)
> 0: jdbc:phoenix:thin:url=http://localhost:876> select dateCol = timestampCol 
> from test;
> +------------------------------------------+
> |          DATECOL = TIMESTAMPCOL          |
> +------------------------------------------+
> | true                                     |
> +------------------------------------------+
> 1 row selected (0.019 seconds)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to