[
https://issues.apache.org/jira/browse/PHOENIX-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15472628#comment-15472628
]
Hadoop QA commented on PHOENIX-2946:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12827490/PHOENIX-2946_v4.patch
against master branch at commit 3a8724eee05aaf477bf6085415e781856990e1c0.
ATTACHMENT ID: 12827490
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
34 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ "CREATE TABLE IF NOT EXISTS T1 (k1 INTEGER NOT NULL, dates
DATE, timestamps TIMESTAMP, times TIME CONSTRAINT pk PRIMARY KEY (k1))";
+ String dml = "UPSERT INTO T1 VALUES (1, TO_DATE('Sat, 3 Feb 2008
03:05:06 GMT', 'EEE, d MMM yyyy HH:mm:ss z', 'UTC'), TO_TIMESTAMP('2006-04-12
15:10:20'), " +
+ dml = "UPSERT INTO T1 VALUES (2, TO_DATE('Sat, 3 Feb 2008 03:05:06
GMT', 'EEE, d MMM yyyy HH:mm:ss z', 'UTC'), TO_TIMESTAMP('2006-04-12
10:10:20'), " +
+ dml = "UPSERT INTO T1 VALUES (3, TO_DATE('Sat, 3 Feb 2008 03:05:06
GMT', 'EEE, d MMM yyyy HH:mm:ss z', 'UTC'), TO_TIMESTAMP('2006-04-12
08:10:20'), " +
+ new DateCodec(), 11); // After TIMESTAMP and DATE to ensure
toLiteral finds those first
+ public Date toObject(byte[] b, int o, int l, PDataType actualType,
SortOrder sortOrder, Integer maxLength, Integer scale) {
+ return equalsAny(targetType, PDate.INSTANCE, PTime.INSTANCE,
PTimestamp.INSTANCE, PVarbinary.INSTANCE, PBinary.INSTANCE);
+ return super.isBytesComparableWith(otherType) || otherType ==
PTime.INSTANCE || otherType == PTimestamp.INSTANCE;
+ Integer maxLength, Integer scale, SortOrder actualModifier,
Integer desiredMaxLength, Integer desiredScale,
+ if (ptr.getLength() > 0 && (actualType == PTimestamp.INSTANCE ||
actualType == PUnsignedTimestamp.INSTANCE)) {
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.phoenix.util.csv.StringToArrayConverterTest
org.apache.phoenix.util.csv.CsvUpsertExecutorTest
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/556//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/556//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/556//console
This message is automatically generated.
> Projected comparison between date and timestamp columns always returns true
> ---------------------------------------------------------------------------
>
> Key: PHOENIX-2946
> URL: https://issues.apache.org/jira/browse/PHOENIX-2946
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.6.0, 4.8.0
> Reporter: Kevin Liew
> Assignee: Kevin Liew
> Priority: Minor
> Labels: comparison, date, timestamp
> Fix For: 4.9.0, 4.8.1
>
> Attachments: PHOENIX-2946_v2.patch, PHOENIX-2946_v3.patch,
> PHOENIX-2946_v4.patch
>
>
> {code}
> 0: jdbc:phoenix:thin:url=http://localhost:876> create table test (dateCol
> DATE primary key, timestampCol TIMESTAMP);
> No rows affected (2.559 seconds)
> 0: jdbc:phoenix:thin:url=http://localhost:876> upsert into test values
> (TO_DATE('1990-01-01'), NOW());
> 1 row affected (0.255 seconds)
> 0: jdbc:phoenix:thin:url=http://localhost:876> select dateCol = timestampCol
> from test;
> +------------------------------------------+
> | DATECOL = TIMESTAMPCOL |
> +------------------------------------------+
> | true |
> +------------------------------------------+
> 1 row selected (0.019 seconds)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
