[
https://issues.apache.org/jira/browse/PHOENIX-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15474210#comment-15474210
]
James Taylor edited comment on PHOENIX-3193 at 9/8/16 3:57 PM:
---------------------------------------------------------------
This patch applies on master and builds. We asked Nishani to combine both the
phoenix-tracing-webapp and the phoenix-zipkin into a single phoenix-tracing
module. This was done in a somewhat strange manner, as the phoenix-tracing
module has two submodules. Maybe this is ok and necessary, but it's not clear
to me why. The patch introduces two new dependencies: springboot and zipkin.
Both look to be ASF 2.0 licensed which is good, but it'd probably be worth the
keen eye of [~elserj] if we want to move forward with it.
The main thing the tracing UI work is an owner, [~rajeshbabu]. We don't have
any reasonable amount of testing on it, the docs are out of date, and no one in
the OS community supports it. Without this, I think we should remove it from
the source and binary distro and host it on github somewhere as an experimental
add-on.
Thoughts?
was (Author: jamestaylor):
This patch applies on master and builds. We asked Nishani to combine both the
phoenix-tracing-webapp and the phoenix-zipkin into a single phoenix-tracing
module. This was done in a somewhat strange manner, as the phoenix-tracing
module has two submodules. Maybe this is ok and necessary, but it's not clear
to me why. The patch introduces two new dependencies: springboot and zipkin.
Both look to be ASF 2.0 licensed which is good, but it'd probably be worth the
keen eye of [~elserj] if we want to move forward with it.
The main thing the tracing UI work is an owner, [~rajeshbabu]. We don't have
any reasonable amount of testing on it and no one to support this in the OS
community. Without this, I think we should remove it from the source and binary
distro and perhaps host it on github somewhere as an experimental add-on.
Thoughts?
> Tracing UI improvements
> -----------------------
>
> Key: PHOENIX-3193
> URL: https://issues.apache.org/jira/browse/PHOENIX-3193
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Mujtaba Chohan
> Assignee: Nishani
> Attachments: PHOENIX-3193.patch
>
>
> Points from GSoC presentation on tracing imporvements:
> *Tracing UI*
> * Remove line chart
> * In list page, run query with description, start_time, (end_time-start_time)
> duration from T where trace_id = ?
> * More space for descriptions on bar chart. Wrap if necessary
> * Label for X axis on timeline sometime again start from 0, if X axis is in
> seconds then it should not rollover after 60 seconds unless minutes are also
> shown
> * X-axis labeled as Node on various charts, but should be Percentage
> *Zipkin*
> * Flip zipkin chart on vertical axis with arrows going other way. So start
> from the top level root on the leftmost side and work toward children on the
> right.
> * Ask zipkin community if there's a way to tell it that date/time is in
> milliseconds.
> *Overall*
> * Please put together a pull request to the phoenix project to add the
> zipkiin work you've done to the OS project. Ideally, include the zipkin work
> in the phoenix-tracing module and call it phoeix-tracing. Only if there is
> some major hurdle, create a new module.
> * Test with trace_ids that have multiple spans with duration (end_time -
> start_time) > 5 ms and verify that UI and Zipkin output shows the correct
> corresponding timeline
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
