[
https://issues.apache.org/jira/browse/PHOENIX-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15474554#comment-15474554
]
ASF GitHub Bot commented on PHOENIX-3193:
-----------------------------------------
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/202#discussion_r78055951
--- Diff: phoenix-tracing/pom.xml ---
@@ -0,0 +1,47 @@
+<?xml version='1.0'?>
+ <!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+
+ <project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
--- End diff --
I would remove this intermediate pom. It serves no purpose and will just
make the build more brittle. Just make phoenix-tracing-webapp and
phoenix-zipkin refer to the parent two-level ups (`../../`).
> Tracing UI improvements
> -----------------------
>
> Key: PHOENIX-3193
> URL: https://issues.apache.org/jira/browse/PHOENIX-3193
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Mujtaba Chohan
> Assignee: Nishani
> Attachments: PHOENIX-3193.patch
>
>
> Points from GSoC presentation on tracing imporvements:
> *Tracing UI*
> * Remove line chart
> * In list page, run query with description, start_time, (end_time-start_time)
> duration from T where trace_id = ?
> * More space for descriptions on bar chart. Wrap if necessary
> * Label for X axis on timeline sometime again start from 0, if X axis is in
> seconds then it should not rollover after 60 seconds unless minutes are also
> shown
> * X-axis labeled as Node on various charts, but should be Percentage
> *Zipkin*
> * Flip zipkin chart on vertical axis with arrows going other way. So start
> from the top level root on the leftmost side and work toward children on the
> right.
> * Ask zipkin community if there's a way to tell it that date/time is in
> milliseconds.
> *Overall*
> * Please put together a pull request to the phoenix project to add the
> zipkiin work you've done to the OS project. Ideally, include the zipkin work
> in the phoenix-tracing module and call it phoeix-tracing. Only if there is
> some major hurdle, create a new module.
> * Test with trace_ids that have multiple spans with duration (end_time -
> start_time) > 5 ms and verify that UI and Zipkin output shows the correct
> corresponding timeline
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
