[
https://issues.apache.org/jira/browse/PHOENIX-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523354#comment-15523354
]
James Taylor commented on PHOENIX-3298:
---------------------------------------
Yes, we'd still want to throw an exception in that case. In general, we
shouldn't have to change any unit tests (and if we do, we need to be very
careful to note any incompatibilities we're introducing). We can introduce a
change in MetaDataClient if that's easier (as [~maryannxue] suggested). I think
the change won't be a pure grammar change. You can likely make the change in
the grammar rule execution, though, when the ColumnDef object is created.
> Create Table: Single column primary key may not be null
> -------------------------------------------------------
>
> Key: PHOENIX-3298
> URL: https://issues.apache.org/jira/browse/PHOENIX-3298
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Eric Lomore
> Assignee: Eric Lomore
>
> Create table statements with a single column currently must have "NOT NULL"
> identifier to pass tests.
> Running this code results in failure
> {code}CREATE TABLE t (k VARCHAR PRIMARY KEY DESC){code}
> While this allows tests to pass
> {code}CREATE TABLE t (k VARCHAR NOT NULL PRIMARY KEY DESC){code}
> Must either enforce the not null condition and update test cases, or apply a
> fix.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
