Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/211#discussion_r80916280
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1499,6 +1502,53 @@ public void createTable(RpcController controller,
CreateTableRequest request,
cell.getTimestamp(),
Type.codeToType(cell.getTypeByte()), bytes);
cells.add(viewConstantCell);
}
+ Short indexId = null;
+ if (request.hasAllocateIndexId() &&
request.getAllocateIndexId()) {
+ String tenantIdStr = tenantIdBytes.length == 0 ? null
: Bytes.toString(tenantIdBytes);
+ final Properties props = new Properties();
+ UpgradeUtil.doNotUpgradeOnFirstConnection(props);
+ try (PhoenixConnection connection =
DriverManager.getConnection(MetaDataUtil.getJdbcUrl(env),
props).unwrap(PhoenixConnection.class)){
+ PName physicalName = parentTable.getPhysicalName();
+ int nSequenceSaltBuckets =
connection.getQueryServices().getSequenceSaltBuckets();
+ SequenceKey key =
MetaDataUtil.getViewIndexSequenceKey(tenantIdStr, physicalName,
+ nSequenceSaltBuckets,
parentTable.isNamespaceMapped() );
+ // TODO Review Earlier sequence was created at
(SCN-1/LATEST_TIMESTAMP) and incremented at the client
max(SCN,dataTable.getTimestamp), but it seems we should
+ // use always LATEST_TIMESTAMP to avoid seeing
wrong sequence values by different connection having SCN
+ // or not.
+ long sequenceTimestamp = HConstants.LATEST_TIMESTAMP;
+ try {
+
connection.getQueryServices().createSequence(key.getTenantId(),
key.getSchemaName(), key.getSequenceName(),
--- End diff --
@ankitsinghal This patch introducing inter table rpc calls but seems it's
needed. What do you think of moving create sequence to meta data client and
perform sequence increment alone here? So that atleast we can reduce the rpc
calls here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
