[ https://issues.apache.org/jira/browse/PHOENIX-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529749#comment-15529749 ]
ASF GitHub Bot commented on PHOENIX-3254: ----------------------------------------- Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/211#discussion_r80925250 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -1445,6 +1445,9 @@ public MetaDataResponse call(MetaDataService instance) throws IOException { builder.addTableMetadataMutations(mp.toByteString()); } builder.setClientVersion(VersionUtil.encodeVersion(PHOENIX_MAJOR_VERSION, PHOENIX_MINOR_VERSION, PHOENIX_PATCH_NUMBER)); + if (allocateIndexId) { --- End diff -- nit: just format code here. > IndexId Sequence is incremented even if index exists already. > ------------------------------------------------------------- > > Key: PHOENIX-3254 > URL: https://issues.apache.org/jira/browse/PHOENIX-3254 > Project: Phoenix > Issue Type: Bug > Reporter: Ankit Singhal > Assignee: Ankit Singhal > Attachments: PHOENIX-3254.patch, PHOENIX-3254_wip.patch > > > As we are incrementing sequence at the client even if we are not going to > create a index (in case index already exists and user is using CREATE INDEX > IF NOT EXISTS) or DDL failed in later stage(due to parent table not found or > something). > If this keeps on happening then user may reach the limit of Short.MAX_VALUE > and TOO_MANY_INDEXES exception will be thrown if user tries to create a new > index. > To prevent, this we should increment sequences when we are about to create a > index at server. -- This message was sent by Atlassian JIRA (v6.3.4#6332)