[ 
https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15535214#comment-15535214
 ] 

Rajeshbabu Chintaguntla commented on PHOENIX-3242:
--------------------------------------------------

[~maryannxue] Thanks for updated patch. 
bq. the single quotes surrounding the class name and the jar path should be 
trimmed when you create the function node, otherwise you'd run into trouble at 
a later stage.
Yes I also found this. Will fix it in parsing stage itself.

bq. So could you please go through this new patch again and see if there's 
anything that needs to be refined?
Definitely I will check and fix them.

Thanks,
Rajeshbabu.

> Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration
> -----------------------------------------------------------------
>
>                 Key: PHOENIX-3242
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3242
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>              Labels: calcite
>         Attachments: PHOENIX-3242-WIP-2.patch, PHOENIX-3242-wip.patch, 
> PHOENIX-3242_select-wip.patch, PHOENIX-3242_v1.patch, PHOENIX-3242_v2.patch, 
> PHOENIX-3242_v3.patch, PHOENIX-3242_v4.patch, PHOENIX-3242_v5.patch, 
> PHOENIX-3242_v6.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to