[ 
https://issues.apache.org/jira/browse/PHOENIX-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15537308#comment-15537308
 ] 

ASF GitHub Bot commented on PHOENIX-2827:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/213#discussion_r81430788
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/execute/ClientScanPlan.java ---
    @@ -106,12 +106,18 @@ public ExplainPlan getExplainPlan() throws 
SQLException {
         }
     
         @Override
    -    public QueryPlan limit(Integer limit) {
    -        if (limit == this.limit || (limit != null && 
limit.equals(this.limit)))
    +    public QueryPlan limit(Integer limit, Integer offset) {
    +        if (limit == this.limit || (limit != null && 
limit.equals(this.limit))) {
    --- End diff --
    
    For right or wrong, Phoenix allows an OFFSET to be used without a LIMIT 
today.


> Support OFFSET in Calcite-Phoenix
> ---------------------------------
>
>                 Key: PHOENIX-2827
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2827
>             Project: Phoenix
>          Issue Type: Task
>            Reporter: Maryann Xue
>            Assignee: Eric Lomore
>              Labels: calcite
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to