Github user lomoree commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/213#discussion_r81431821
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/execute/ClientScanPlan.java ---
    @@ -106,12 +106,18 @@ public ExplainPlan getExplainPlan() throws 
SQLException {
         }
     
         @Override
    -    public QueryPlan limit(Integer limit) {
    -        if (limit == this.limit || (limit != null && 
limit.equals(this.limit)))
    +    public QueryPlan limit(Integer limit, Integer offset) {
    +        if (limit == this.limit || (limit != null && 
limit.equals(this.limit))) {
    --- End diff --
    
    Ah, my mistake. I'll get working on a patch that also supports offset 
without limit. This should incorporate all of the changes noted above. Thanks 
for clarifying.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to