Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/214#discussion_r82285685 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java --- @@ -1453,7 +1453,7 @@ public void testInvalidPrimaryKeyDecl() throws Exception { } } } - + --- End diff -- @lomoree It's nice to avoid these trailing spaces, but most of the time, we need to avoid such changes in our patch, especially for 'calcite' branch at the moment, for it would make future merge to master more difficult.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---