[ 
https://issues.apache.org/jira/browse/PHOENIX-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15562986#comment-15562986
 ] 

Samarth Jain commented on PHOENIX-2675:
---------------------------------------

[~jamestaylor] - it looks like your latest patch has commits from other JIRAs 
too. Would you mind attaching a patch with just this JIRA's changes as it would 
make it easier for me to review. Also, it looks like there is some commented 
code included in this patch. For ex :

{code}
+//        TestUtil.analyzeTable(conn, fullTableName);
+//        List<KeyRange> guideposts = TestUtil.getAllSplits(conn, 
fullTableName);
+//        assertEquals(1, guideposts.size());
+//        assertEquals(KeyRange.EVERYTHING_RANGE, guideposts.get(0));
+//        
+//        conn.createStatement().execute("ALTER TABLE " + fullTableName + " 
SET GUIDE_POST_WIDTH=20");
+//        
+//        TestUtil.analyzeTable(conn, fullTableName);
+//        guideposts = TestUtil.getAllSplits(conn, fullTableName);
+//        assertEquals(5, guideposts.size());
+//
+//        // Confirm that when view index used, the GUIDE_POST_WIDTH from the 
data physical table
+//        // was used
+//        sql = "SELECT * FROM " + viewName + " WHERE v2 > 100";
+//        stmt = conn1.prepareStatement(sql);
+//        stmt.executeQuery();
+//        QueryPlan plan = stmt.unwrap(PhoenixStatement.class).getQueryPlan();
+//        assertEquals(5, plan.getSplits().size());
{code}



> Allow stats to be configured on a table-by-table basis
> ------------------------------------------------------
>
>                 Key: PHOENIX-2675
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2675
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: James Taylor
>            Assignee: James Taylor
>             Fix For: 4.9.0
>
>         Attachments: PHOENIX-2675.patch, PHOENIX-2675_wip.patch, 
> PHOENIX-2675_wip2.patch
>
>
> Currently stats are controlled and collected at a global level. We should 
> allow them to be configured on a table-by-table basis.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to