[
https://issues.apache.org/jira/browse/PHOENIX-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563246#comment-15563246
]
James Taylor commented on PHOENIX-3367:
---------------------------------------
I think it's fine to update the tests, [~maryannxue]. FWIW, the SPLIT ON bind
variables can be of any type (VARCHAR, BIGINT, etc).
> Replace usage of bind variables in BaseTest.createTestTable()
> -------------------------------------------------------------
>
> Key: PHOENIX-3367
> URL: https://issues.apache.org/jira/browse/PHOENIX-3367
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Maryann Xue
> Priority: Minor
> Labels: calcite
>
> We don't support bind variables in DDL yet, due to
> https://issues.apache.org/jira/browse/CALCITE-1319. So we can probably
> replace usage of bind variables in BaseTest.createTestTable() with sql string
> construction. In a previous check-in, I commented out
> BaseTest.getDefaultSplits() so that this wouldn't have big impact on the pass
> rate, but once this issue is solved, we can uncomment those lines. Anyway, do
> you think this is the right thing to do for now, [~jamestaylor]? or should we
> wait on CALCITE-1319?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
