[ https://issues.apache.org/jira/browse/PHOENIX-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15594811#comment-15594811 ]
Ankit Singhal commented on PHOENIX-3393: ---------------------------------------- LGTM as well. Thanks [~rayokota] for the contribution. Checked code for other areas if above optimization can be applied, but didn't find any code with randomAccessList(like Arraylist) and having significant remove operations. Committed your change to 4.x branches and master. > Use Iterables.removeIf instead of Iterator.remove in HBase filters > ------------------------------------------------------------------ > > Key: PHOENIX-3393 > URL: https://issues.apache.org/jira/browse/PHOENIX-3393 > Project: Phoenix > Issue Type: Improvement > Reporter: Robert Yokota > Assignee: Robert Yokota > Priority: Minor > Fix For: 4.9.0 > > Attachments: PHOENIX-3393.master.001.patch > > > This is a performance improvement to use Iterables.removeIf in the > filterRowCells method of ColumnProjectionFilter as described here: > https://rayokota.wordpress.com/2016/10/20/tips-on-writing-custom-hbase-filters/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)